This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Warn when migrating e2e data to indexeddb #1654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
reviewed
Dec 6, 2017
| "This will have caused end-to-end cryptography to malfunction "+ | ||
| "in the older version. End-to-end encrypted messages exchanged "+ | ||
| "recently whilst using the older version may not be decryptable "+ | ||
| "in this version.", |
There was a problem hiding this comment.
... and nor may messages exchanged in future, because people think you have different device keys. log out, export keys, etc etc
sigh. I can't think of a way. |
also a comma
|
Mm, we could probably think about having a class that sits & listens for general things like this and pops up dialogs. It would still have to be started & stopped by MatrixClientPeg though. Either way, probably one for a refactor down the line. |
richvdh
approved these changes
Dec 8, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Twinned with matrix-org/matrix-js-sdk#586